Added BogoSort in Swift 4.1 #161

Wesley-Arrington · 2018-06-29T09:46:00Z

Added BogoSort in Swift 4.1

Butt4cak3 · 2018-06-29T10:03:10Z

Welcome @CDsigma! Thanks for the contribution!

You're the first person to submit Swift code to the Algorithm Archive. You correctly added the code import to the .md file, but currently it doesn't know what lang="swift" means. For that, you have to go into book.json (which is at the root of this repository), scroll down to where all the programming languages are listed and add Swift like so:

				...
				{
					"lang": "go",
					"name": "Go"
				},
				{
					"lang": "swift",
					"name": "Swift"
				}

I don't know if we have a Swift programmer to review your code, but we will see what we can do. Your code looks pretty good, so I'm sure it will get merged soon.

If you want, you can also add your name to the end of the CONTRIBUTORS.md file, but you don't have to.

Butt4cak3 · 2018-06-29T10:30:26Z

Perfect. I totally didn't catch that you only changed lang:"swift" but not the other "lang="swift" attribute, but now it should be good. Now to wait for a Swift developer to show up. If we can't find one, I'll try to get your PR merged tomorrow or the day after.

Wesley-Arrington · 2018-06-29T10:32:42Z

Awesome :)

Thanks for your help 😊

zsparal · 2018-06-29T10:55:46Z

One small note: you commited with a git user/email different from your GitHub one. Was this intentional? If not, feel free to fix it and force push your changes.

jiegillet · 2018-06-29T12:08:42Z

chapters/sorting_searching/bogo/code/swift/bogoSort.swift

+
+
+func isSorted(inputArray: [Int]) -> Bool {
+


Nitpick 1: 2 out of 3 functions start with an empty line. I don't know which style is best, but I do know that consistency is always rule number 1 :)

Ya that's a good note I'll make the line spacing consistent in each function

jiegillet · 2018-06-29T12:10:32Z

chapters/sorting_searching/bogo/code/swift/bogoSort.swift

+
+
+
+func shuffle(inputArray: inout [Int]) -> [Int] {


Nitpick 2: a quick Google search showed me that there is a native shuffle function in Swift 4.2+. Maybe it's best to use it.

I wonder if there's a reason to use version 4.1 specifically.

Oh my bad, I had not seen the version was specifically 4.1, it's right there in the title -_-
But yeah, I'd like to hear the reason too then :)

Most people who use Swift tend to use the version which comes with Xcode. Currently the stable build of Xcode uses Swift 4.1 so I thought that would be the best choice.

There is an Xcode 10 beta which uses Swift 4.2 but that won't be the stable build for a few months so until then I think Swift 4.1 is the best choice.

Wesley-Arrington · 2018-06-29T17:40:19Z

@Gustorn Ya I noticed that just after I committed. I didn't mean to do it but I also don't mind so I think I'll leave it 🤷

zsparal · 2018-06-29T17:42:35Z

@CDsigma sure thing, I just thought I'd mention it since sometimes people accidentally commit with their work email (did it once or twice myself) and they'd rather not have that online. If you're OK with the current one it's all good.

I accidentally had messed up the location of some the brackets

This update should fix the location of the brackets

Okay now I have actually formatted the brackets correctly

Butt4cak3 · 2018-06-29T20:38:09Z

The squashed commit will have the right author, I think. It won't really matter in the end.

Butt4cak3

Now that you and @jiegillet figured some things out, I have some small changes that I'd like you to make. Once they're done, I think this one is ready to merge!

Butt4cak3 · 2018-06-29T21:16:36Z

book.json

+					"lang": "swift",
+					"name": "Swift"
+     				},
+      				{


The two lines with the brackets are indented with a bunch of spaces and then 3 tabs. The file is tab indented. Try to make sure you only use tabs.

Sorry about that just committed some changes so no more spaces are used

Butt4cak3 · 2018-06-29T21:18:40Z

chapters/sorting_searching/bogo/bogo_sort.md

@@ -36,6 +36,9 @@ In code, it looks something like this:
 {% sample lang="rs" %}
 [import, lang:"rust"](code/rust/bogosort.rs)
 {% endmethod %}
+{% sample lang="swift" %}
+[import, lang:"swift"](code/swift/bogoSort.swift)


I don't like the capitalization of the "S" in the file name. Some languages (like Java) require capitalization to match classes and such inside the files, but I'd prefer to keep everything else lowercase.

Unless it's some kind of convention in Swift. In that case, keep it.

Just updated the file name 👍

Butt4cak3 · 2018-06-29T21:47:00Z

Since we all don't really know Swift, I'll just take the liberty to merge this one. The logic of the code is correct and so it shouldn't be an issue.

Butt4cak3 · 2018-06-29T21:50:36Z

Nevermind. I just found a mistake that breaks the build. You have to fix this before I can merge.

Butt4cak3 · 2018-06-29T21:51:10Z

chapters/sorting_searching/bogo/bogo_sort.md

@@ -36,6 +36,9 @@ In code, it looks something like this:
 {% sample lang="rs" %}
 [import, lang:"rust"](code/rust/bogosort.rs)
 {% endmethod %}
+{% sample lang="swift" %}
+[import, lang:"swift"](code/swift/bogosort.swift)
+{% endmethod %}


There's only supposed to be one {% endmethod %} statement at the end. You have to remove the one in line 38.

Wesley Arrington added 2 commits June 29, 2018 02:39

Added BogoSort in Swift 4.1

f5ccae7

Updated .md

3e82fd1

Butt4cak3 added the Implementation This provides an implementation for an algorithm. (Code and maybe md files are edited.) label Jun 29, 2018

Wesley Arrington and others added 3 commits June 29, 2018 03:19

Updated book.json

090d5b7

Updating .md

fa07e5e

Updated CONTRIBUTORS.md

b68abf2

jiegillet reviewed Jun 29, 2018

View reviewed changes

Fixing Formatting

e4c61b1

Wesley-Arrington added 5 commits June 29, 2018 11:05

Merge branch 'master' into master

8450b8c

Fixing formatting

ba208f7

I accidentally had messed up the location of some the brackets

Fixing Formating

2f1723b

This update should fix the location of the brackets

Fixed Brackets

cae4e82

Okay now I have actually formatted the brackets correctly

Fixing Brackets

e4e82c3

Merge branch 'master' into master

a88b732

Butt4cak3 requested changes Jun 29, 2018

View reviewed changes

Wesley-Arrington added 3 commits June 29, 2018 14:26

Updated File Name

f18feab

Got rid of spaces in whitespace

8c3b742

Renamed bogosort.swift file

0a0fc50

Butt4cak3 approved these changes Jun 29, 2018

View reviewed changes

Butt4cak3 reviewed Jun 29, 2018

View reviewed changes

Wesley-Arrington added 2 commits June 29, 2018 14:52

Removing duplicate {% endmethod %}

414a7e8

Merge branch 'master' of https://github.com/CDsigma/algorithm-archive

9578b02

Butt4cak3 merged commit f344b76 into algorithm-archivists:master Jun 29, 2018

Uh oh!

Added BogoSort in Swift 4.1 #161

Added BogoSort in Swift 4.1 #161

Uh oh!

Conversation

Wesley-Arrington commented Jun 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Butt4cak3 commented Jun 29, 2018

Uh oh!

Butt4cak3 commented Jun 29, 2018

Uh oh!

Wesley-Arrington commented Jun 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zsparal commented Jun 29, 2018

Uh oh!

jiegillet Jun 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Wesley-Arrington commented Jun 29, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zsparal commented Jun 29, 2018

Uh oh!

Butt4cak3 commented Jun 29, 2018

Uh oh!

Butt4cak3 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Butt4cak3 commented Jun 29, 2018

Uh oh!

Butt4cak3 commented Jun 29, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Wesley-Arrington commented Jun 29, 2018 •

edited

Loading

Wesley-Arrington commented Jun 29, 2018 •

edited

Loading

jiegillet Jun 29, 2018 •

edited

Loading

Wesley-Arrington commented Jun 29, 2018 •

edited

Loading